Change in libosmo-sccp[master]: ipa_asp_fsm: Fix AS lookup from IPA ASP

laforge gerrit-no-reply at lists.osmocom.org
Mon Apr 26 08:54:09 UTC 2021


Hello Jenkins Builder, pespin, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/libosmo-sccp/+/23891

to look at the new patch set (#3).

Change subject: ipa_asp_fsm: Fix AS lookup from IPA ASP
......................................................................

ipa_asp_fsm: Fix AS lookup from IPA ASP

Contrary to proper SIGTRAN, IPA/SCCPlite cannot support multiple
AS within one ASP.  When looking up the AS from the ASP, we cannot
blindly use routing context 0 to find the AS, as there may very well
be multiple IPA AS, and all of those have routing context 0.

As a result, the exiting look-up by osmo_ss7_as_find_by_rctx(inst, 0)
will return the wrong AS, and we will try to add/delete routes for
a completely different AS when ASPs are coming up or going down.

Instead, we need to use xua_find_as_for_asp() in order do the look-up:
It will resolve the single AS within the ASP.

Change-Id: Id295daf84f6ba1cc56cbe1761f874bea329e17ea
Cloess: SYS#5422
---
M src/xua_asp_fsm.c
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/91/23891/3
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23891
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Id295daf84f6ba1cc56cbe1761f874bea329e17ea
Gerrit-Change-Number: 23891
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210426/f1b0faa0/attachment.htm>


More information about the gerrit-log mailing list