Change in libosmo-sccp[master]: ipa: Use VTY-configured default network indicator

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 25 12:44:12 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/23888 )

Change subject: ipa: Use VTY-configured default network indicator
......................................................................

ipa: Use VTY-configured default network indicator

When we receive a message from an IPA/SCCPlite connection, we only
have SCCP global titles and no underlying M3UA.  We since have
to introduce a fake M3UA header.  While we correctly set the SI,
OPC and DPC, we didn't set the NI to what is configured as default
for the cs7 instance in the VTY.  For international, this problem
was hidden by the fact that international is '0' and hence our
default memory initialization.

Change-Id: I02c618fa0a0aa2a859fcd56397df9637043c8e6e
Closes: SYS#5421
---
M src/ipa.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/ipa.c b/src/ipa.c
index d7a929d..93edef8 100644
--- a/src/ipa.c
+++ b/src/ipa.c
@@ -273,6 +273,7 @@
 	data_hdr.si = MTP_SI_SCCP;
 	data_hdr.opc = osmo_htonl(opc);
 	data_hdr.dpc = osmo_htonl(dpc);
+	data_hdr.ni = as->inst->cfg.network_indicator;
 	/* Create M3UA message in XUA structure */
 	xua = m3ua_xfer_from_data(&data_hdr, msgb_l2(msg), msgb_l2len(msg));
 	msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/23888
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I02c618fa0a0aa2a859fcd56397df9637043c8e6e
Gerrit-Change-Number: 23888
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210425/c9397417/attachment.htm>


More information about the gerrit-log mailing list