Change in osmo-pcap[master]: use osmo_wqueue_enqueue_quiet() as we log anyway

laforge gerrit-no-reply at lists.osmocom.org
Sat Apr 24 08:42:17 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/23873 )

Change subject: use osmo_wqueue_enqueue_quiet() as we log anyway
......................................................................

use osmo_wqueue_enqueue_quiet() as we log anyway

There's no need in both libosmocore and osmo-pcap-client logging
the same queue overflow twice.

Change-Id: I43881f2bd0b0870a51f9ca5dad2d8cba40d1e54b
---
M src/osmo_client_network.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo_client_network.c b/src/osmo_client_network.c
index 32d450f..c6de579 100644
--- a/src/osmo_client_network.c
+++ b/src/osmo_client_network.c
@@ -58,7 +58,7 @@
 
 static void write_data(struct osmo_pcap_client_conn *conn, struct msgb *msg)
 {
-	if (osmo_wqueue_enqueue(&conn->wqueue, msg) != 0) {
+	if (osmo_wqueue_enqueue_quiet(&conn->wqueue, msg) != 0) {
 		LOGP(DCLIENT, LOGL_ERROR, "Failed to enqueue conn=%s\n", conn->name);
 		rate_ctr_inc(&conn->client->ctrg->ctr[CLIENT_CTR_QERR]);
 		msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/23873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I43881f2bd0b0870a51f9ca5dad2d8cba40d1e54b
Gerrit-Change-Number: 23873
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210424/7b29631c/attachment.htm>


More information about the gerrit-log mailing list