Change in osmo-pcap[master]: use osmo_wqueue_enqueue_quiet() as we log anyway

laforge gerrit-no-reply at lists.osmocom.org
Fri Apr 23 11:29:01 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/23873 )


Change subject: use osmo_wqueue_enqueue_quiet() as we log anyway
......................................................................

use osmo_wqueue_enqueue_quiet() as we log anyway

There's no need in both libosmocore and osmo-pcap-client logging
the same queue overflow twice.

Change-Id: I43881f2bd0b0870a51f9ca5dad2d8cba40d1e54b
---
M src/osmo_client_network.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/73/23873/1

diff --git a/src/osmo_client_network.c b/src/osmo_client_network.c
index 32d450f..c6de579 100644
--- a/src/osmo_client_network.c
+++ b/src/osmo_client_network.c
@@ -58,7 +58,7 @@
 
 static void write_data(struct osmo_pcap_client_conn *conn, struct msgb *msg)
 {
-	if (osmo_wqueue_enqueue(&conn->wqueue, msg) != 0) {
+	if (osmo_wqueue_enqueue_quiet(&conn->wqueue, msg) != 0) {
 		LOGP(DCLIENT, LOGL_ERROR, "Failed to enqueue conn=%s\n", conn->name);
 		rate_ctr_inc(&conn->client->ctrg->ctr[CLIENT_CTR_QERR]);
 		msgb_free(msg);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/23873
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I43881f2bd0b0870a51f9ca5dad2d8cba40d1e54b
Gerrit-Change-Number: 23873
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210423/08f19895/attachment.htm>


More information about the gerrit-log mailing list