Change in osmo-pcu[master]: pdch: tbf_by_tfi(): Allow returning TBFs in state RELEASING

pespin gerrit-no-reply at lists.osmocom.org
Thu Apr 22 19:13:26 UTC 2021


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23871 )


Change subject: pdch: tbf_by_tfi(): Allow returning TBFs in state RELEASING
......................................................................

pdch: tbf_by_tfi(): Allow returning TBFs in state RELEASING

During RELEASING state the TFI, USFs, etc. are still reserved and
assigned to the TBF, and hence the TBF may still use it.
If callers of this function rely on not taking TBFs under RELEASING
state, they should check that explicitly.

It still makes sense being to operate on RELEASING TBFs, since under
some circumstances the TBF may go under a previous state. See for
instance 3GPP TS 44.060 sec 8.1.1.3a.2:

"""
If N3101 reaches the value N3101max, the network shall stop sending
PACKET UPLINK ACK/NACK messages to the mobile station for that TBF
and shall start timer T3169 for the TBF. If an RLC/MAC block is received
from the TBF when timer T3169 is running, the network shall stop timer
T3169 and resume sending PACKET UPLINK ACK/NACK messages to the TBF.
When T3169 expires, the network may consider the TBF as released and
reuse the TFI value.
"""

Change-Id: Ibb471e727388512d42794d3faa26597e2545b852
---
M src/pdch.cpp
1 file changed, 1 insertion(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/71/23871/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index baac0f7..76ca1d0 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -1044,14 +1044,7 @@
 
 	tbf = m_tbfs[dir][tfi];
 
-	if (!tbf)
-		return NULL;
-
-	if (tbf->state_is_not(GPRS_RLCMAC_RELEASING)) {
-		return tbf;
-	}
-
-	return NULL;
+	return tbf;
 }
 
 void gprs_rlcmac_pdch::attach_tbf(gprs_rlcmac_tbf *tbf)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23871
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ibb471e727388512d42794d3faa26597e2545b852
Gerrit-Change-Number: 23871
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210422/5ee7873a/attachment.htm>


More information about the gerrit-log mailing list