This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23860 to look at the new patch set (#2). Change subject: gtp: Rework parsing logic of UpdatePdpCtxResponse ...................................................................... gtp: Rework parsing logic of UpdatePdpCtxResponse The previous order of parsing lead to non-optimal information gathering when pushing events to upper layers. This patch rearranges parsing of packet data to always gather as much info as possible for the benefit of the upper layer. This way it can gather information such as the cause, which is important in the case of "Non-existent", since user should then drop the context. First we want to parse the recovery state, but delay cb to upper layers until we tried to gather the pdp ctx (meaning all except that pdp ctx should be freed). Second, we want to parse the cause, in order to know if there's an associated pdp ctx we can gather from TEID. Third, once we know if we should expect a meaningul TEID, parse it. Related: SYS#5435 Change-Id: Idd10b494e8fbac8703c49ecd8f9bbe4246e51c57 --- M gtp/gtp.c 1 file changed, 30 insertions(+), 19 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/60/23860/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/23860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Idd10b494e8fbac8703c49ecd8f9bbe4246e51c57 Gerrit-Change-Number: 23860 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210422/23cccf29/attachment.htm>