Change in libosmocore[master]: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 21 18:21:55 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23795 )

Change subject: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef
......................................................................


Patch Set 2: -Code-Review

I finally kept the use of tlv_definition because in this specific case I saw no real benefit in using more complex osmo_tlv_prot_def one. In this case we define one message (actually a container IE "Old BSS to New BSS Info") with all-optional IEs, so there's no beefit in going for osmo_tlv_prot_def.

I dropped the function getter indirection as requested.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23795
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e55e947b6fef6dad0cf1a6c16b781bef4cc76c5
Gerrit-Change-Number: 23795
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 18:21:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/f32163b0/attachment.htm>


More information about the gerrit-log mailing list