Change in pysim[master]: filesystem: fix wrong helpstring for update_record_decoded

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 21 16:39:06 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23818 )

Change subject: filesystem: fix wrong helpstring for update_record_decoded
......................................................................

filesystem: fix wrong helpstring for update_record_decoded

the helpstring of update_record_decoded mentions hex bytes for the data
parameter, but it should be mentioned as abstract json data like in
update_binary_decoded

Change-Id: Ibae2ab49054ac5dd6fcccddd28c98d886403dac9
Related: OS#4963
---
M pySim/filesystem.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/pySim/filesystem.py b/pySim/filesystem.py
index 82b4409..2023495 100644
--- a/pySim/filesystem.py
+++ b/pySim/filesystem.py
@@ -638,7 +638,7 @@
 
         upd_rec_dec_parser = argparse.ArgumentParser()
         upd_rec_dec_parser.add_argument('record_nr', type=int, help='Number of record to be read')
-        upd_rec_dec_parser.add_argument('data', help='Data bytes (hex format) to write')
+        upd_rec_dec_parser.add_argument('data', help='Abstract data (JSON format) to write')
         upd_rec_dec_parser.add_argument('--json-path', type=str,
                                         help='JSON path to modify specific element of record only')
         @cmd2.with_argparser(upd_rec_dec_parser)

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23818
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ibae2ab49054ac5dd6fcccddd28c98d886403dac9
Gerrit-Change-Number: 23818
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/ce3b5a1a/attachment.htm>


More information about the gerrit-log mailing list