Change in osmo-ttcn3-hacks[master]: pcu: Fix TC_n3105_max_t3195

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 21 16:17:37 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23810 )

Change subject: pcu: Fix TC_n3105_max_t3195
......................................................................

pcu: Fix TC_n3105_max_t3195

The previously request Dummy block was processed later in an unrelated
place of the test, hence making expectations fail.

The condition T_3195.running doesn't really change the logic/behavior,
but removes an annoying warning in log files everytime the alt step is
run.

Change-Id: I4aa25d1220ccbeb8f1870f36651c9d6793a452b1
---
M pcu/PCU_Tests.ttcn
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index d4fe004..e946d96 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1746,9 +1746,13 @@
 					  block_nr := nr.blk_nr));
 		repeat;
 	}
-	[] T_3195.timeout {
+	[T_3195.running] T_3195.timeout {
 		log("T_3195 timeout");
-		/* Done in alt */
+		/* Done in alt, wait for pending RTS initiated previously in
+		 * above case before continuing (expect /* Dummy block): */
+		BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+						tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
+						tr_RLCMAC_DUMMY_CTRL));
 		}
 	[] BTS.receive {
 		setverdict(fail, "Unexpected BTS message");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23810
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4aa25d1220ccbeb8f1870f36651c9d6793a452b1
Gerrit-Change-Number: 23810
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/1eacac86/attachment.htm>


More information about the gerrit-log mailing list