Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_n3103_max_t3169

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 21 16:11:46 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811 )

Change subject: pcu: Introduce test TC_n3103_max_t3169
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811/1/pcu/PCU_Tests.ttcn@1469 
PS1, Line 1469: nr := ts_TsTrxBtsNum
This second assignment creates an impression that nr is getting changed somewhere? Is it?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811/1/pcu/PCU_Tests.ttcn@1494 
PS1, Line 1494:    
Again mix of code and comments. This is why I am against this comment formatting style.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811/1/pcu/PCU_Tests.ttcn@1505 
PS1, Line 1505: /*
coding style



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23811
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I90661ce249ff2a2040b9e82688cf413eb65e0c8e
Gerrit-Change-Number: 23811
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 16:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/081e2423/attachment.htm>


More information about the gerrit-log mailing list