Change in osmo-bts[master]: Abis manual: add RSL_IE_OSMO_TRAINING_SEQUENCE

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 21 15:54:42 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23849 )

Change subject: Abis manual: add RSL_IE_OSMO_TRAINING_SEQUENCE
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/23849/2/doc/manuals/abis/rsl.adoc 
File doc/manuals/abis/rsl.adoc:

https://gerrit.osmocom.org/c/osmo-bts/+/23849/2/doc/manuals/abis/rsl.adoc@1012 
PS2, Line 1012: length of the value part
The length part looks redundant to me, TV format would be enough.


https://gerrit.osmocom.org/c/osmo-bts/+/23849/2/doc/manuals/abis/rsl.adoc@1013 
PS2, Line 1013: | octet 3 |  TSC set
And using two separate octets for such small range values also looks redundant to me, I would define it as follows:

  | 7 6 5 4 3 2 1 0 | Bitmask / description
  | . . . . . x x x | TSC
  | . . . x x . . . | TSC Set
  | x x x . . . . . | Reserved



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23849
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie583bd5969fdb45f772af198033e58d7c4077306
Gerrit-Change-Number: 23849
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Apr 2021 15:54:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/6cb6a668/attachment.htm>


More information about the gerrit-log mailing list