Change in osmo-bts[master]: osmo-bts-trx: refactor handling of version specific TRXD parts

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 21 15:21:18 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23832 )

Change subject: osmo-bts-trx: refactor handling of version specific TRXD parts
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23832/3/src/osmo-bts-trx/trx_if.c 
File src/osmo-bts-trx/trx_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23832/3/src/osmo-bts-trx/trx_if.c@905 
PS3, Line 905: } trx_data_codec[16] = {
> It's basically the maximum number of versions we can have. […]
why not simply checking explicitly by maximum supported version? I think we even have a define for that maximum version somewhere, we use it to negotiate the version. This way we don't need to have extra space unsued for no reason.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23832
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7aedd85a8d4f6d6191cd3b75272a688208fb2879
Gerrit-Change-Number: 23832
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Apr 2021 15:21:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/82d92e3c/attachment.htm>


More information about the gerrit-log mailing list