Change in osmo-bts[master]: osmo-bts-trx: reduce and share TRXC message buffer size

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 21 14:36:40 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23825 )

Change subject: osmo-bts-trx: reduce and share TRXC message buffer size
......................................................................


Patch Set 3: Code-Review-1

I don't see any problem with allocating 1500 bytes in the stack. It's the same cost operationally speaking, and I don't think that will cause a stack overflow.
Using a smaller number would probably mean we need to use more CPU to do extra checks as laforge suggests, so not sure it's worth it.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23825
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I21c9ef37954c73ab74f07a3d226707744cbb2f01
Gerrit-Change-Number: 23825
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 14:36:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/2685d3e3/attachment.htm>


More information about the gerrit-log mailing list