Change in libosmocore[master]: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 21 11:13:46 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23795 )

Change subject: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23795/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/23795/1/src/gsm/gsm0808.c@1580 
PS1, Line 1580: static
> I agree there is not really any reason to do so. […]
I did it that way to follow same way of bss_att_tlvdef, that's all.

Ok, I'll have a look at using osmo_tlv_prot_def.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23795
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e55e947b6fef6dad0cf1a6c16b781bef4cc76c5
Gerrit-Change-Number: 23795
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 11:13:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/f38d4082/attachment.htm>


More information about the gerrit-log mailing list