Change in osmo-ttcn3-hacks[master]: deps/Makefile: Switch branches to related commit hashes

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 21 07:08:55 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23793 )

Change subject: deps/Makefile: Switch branches to related commit hashes
......................................................................

deps/Makefile: Switch branches to related commit hashes

Change-Id: Ia846863eff1734eca469257b9a8d5e653a45e835
---
M deps/Makefile
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/deps/Makefile b/deps/Makefile
index d270a79..64e293b 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -76,8 +76,9 @@
 ALL_REPOS=$(ECLIPSEGITHUB_REPOS) $(ECLIPSEGIT2_REPOS) $(OSMOGITHUB_REPOS) $(OSMOGIT_REPOS)
 
 # Tag names from 'git-describe --tags'; if not available, a commit hash may be used instead.
-# In order to keep local changes in the repository of a dependency, set its commit to the
-# name of a local branch here (e.g. 'master').
+# Do not put references to branches here, except for local testing: this breaks the caching
+# logic of docker containers, which only invalidate their cached ttcn3 dependencies if this
+# file changed.
 titan.Libraries.TCCUsefulFunctions_commit=	R.35.B-6-gb3687da
 titan.ProtocolEmulations.M3UA_commit=		f086e78d74defa044d864f17adaad9433fedc961
 titan.ProtocolEmulations.SCCP_commit=	 	R.7.A-11-gd4b7a6d
@@ -127,8 +128,8 @@
 titan.TestPorts.TELNETasp_commit=		873fe539642542cd9a901c208f1ec11c6d2f5387
 titan.TestPorts.UDPasp_commit=			c20d77a34f288dd70dd4aaa30e520778876e9336
 titan.TestPorts.UNIX_DOMAIN_SOCKETasp_commit=	R.2.A-13-gd34ab71
-titan.TestPorts.USB_commit=			master
-osmo-uecups_commit=				master
+titan.TestPorts.USB_commit=			4c742e931aae66c0046cebfe3c1de4618b6f9ffc
+osmo-uecups_commit=				8362efef7c6fa341eb947a75786878e0685767b7
 
 all: $(foreach dir,$(ALL_REPOS),$(dir)/update)
 clean: $(foreach dir,$(ALL_REPOS),$(dir)/clean)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23793
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ia846863eff1734eca469257b9a8d5e653a45e835
Gerrit-Change-Number: 23793
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/7501f72a/attachment.htm>


More information about the gerrit-log mailing list