Change in pysim[master]: pySim-shell: separate export summary with a headline

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 21 06:44:59 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23803 )

Change subject: pySim-shell: separate export summary with a headline
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23803/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23803/1/pySim-shell.py@293 
PS1, Line 293: 		headli
so we are appending 80 spaces....
only to then cut out only a chunk of 77 characters from that one line below?  I find that somewhat odd, and cannot really undersatnd why.  Why are you not formatting the whole line in one? if for some reason that's not possible with string concatenation, simply use the '%' operator like '# %77s #' % ('Export summary')

And actually, I would move all of that to a function "print a heading with a surrounding box".  Or, as we are using poutput(), maybe rathe "create a string containing a boxed heading" so one can simply say

self._cmd.poutput(format_as_box('Export summary')).



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23803
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I90771e525b2b114bdb41a8e90d298ca991c09c3d
Gerrit-Change-Number: 23803
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 21 Apr 2021 06:44:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210421/568e8f72/attachment.htm>


More information about the gerrit-log mailing list