This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/23831 ) Change subject: osmo-bts-trx: cosmetic: get rid of TRX_CHDR_LEN macro ...................................................................... osmo-bts-trx: cosmetic: get rid of TRX_CHDR_LEN macro The 'CHDR' stands for 'Common Header', but this does not apply to TRXDv2 because TDMA frame number may not be present in the batched PDUs. Let's avoid potential confusion by removing it. Change-Id: I80495df474c432f4c0a4cfa6f917821d7b35859a --- M src/osmo-bts-trx/trx_if.c 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/23831/1 diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index 4364acf..a458fa6 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -718,11 +718,9 @@ * TRX burst data socket */ -/* Common header length: 1/2 VER + 1/2 TDMA TN + 4 TDMA FN */ -#define TRX_CHDR_LEN (1 + 4) -/* Uplink v0 header length: 1 RSSI + 2 ToA256 */ -#define TRX_UL_V0HDR_LEN (TRX_CHDR_LEN + 1 + 2) -/* Uplink v1 header length: + 1 MTS + 2 C/I */ +/* Uplink TRXDv0 header length: TDMA TN + FN + RSSI + ToA256 */ +#define TRX_UL_V0HDR_LEN (1 + 4 + 1 + 2) +/* Uplink TRXDv1 header length: additional MTS + C/I */ #define TRX_UL_V1HDR_LEN (TRX_UL_V0HDR_LEN + 1 + 2) /* TRXD header dissector for version 0 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I80495df474c432f4c0a4cfa6f917821d7b35859a Gerrit-Change-Number: 23831 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/c06c1032/attachment.htm>