Change in libosmocore[master]: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef

fixeria gerrit-no-reply at lists.osmocom.org
Tue Apr 20 18:12:56 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23795 )

Change subject: gsm0808: Introduce gsm0808_old_bss_to_new_bss_info_att_tlvdef
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23795/1/src/gsm/gsm0808.c 
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/c/libosmocore/+/23795/1/src/gsm/gsm0808.c@1580 
PS1, Line 1580: static
Is there any reason to keep this symbol static if you expose it via the function below anyway? What do we benefit from keeping it encapsulated/protected like that? I see that the same is done for bss_att_tlvdef, but still wondering.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23795
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0e55e947b6fef6dad0cf1a6c16b781bef4cc76c5
Gerrit-Change-Number: 23795
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Apr 2021 18:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/79ddb550/attachment.htm>


More information about the gerrit-log mailing list