Change in osmo-ttcn3-hacks[master]: f_channel_needs_modify(): ask actual TCH lchan mode via VTY

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 20 09:40:55 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23807 )

Change subject: f_channel_needs_modify(): ask actual TCH lchan mode via VTY
......................................................................


Patch Set 1:

I mean, we shouldn't rely on what osmo-bsc tells us about it, since we are actually testing it. We should know from the test what to expect without asking. Perhaps passing g_pars.expect_channel_mode_modify there or similar would help?


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23807
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If30e2cec65da91cb5899ee29e2afb6696437a4c9
Gerrit-Change-Number: 23807
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Apr 2021 09:40:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/0077bd20/attachment.htm>


More information about the gerrit-log mailing list