Change in osmo-ttcn3-hacks[master]: pcu: Fix DATA.ind with SAPI BCCH wrongly txed as PDTCH

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 20 08:18:26 UTC 2021


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23801 )

Change subject: pcu: Fix DATA.ind with SAPI BCCH wrongly txed as PDTCH
......................................................................

pcu: Fix DATA.ind with SAPI BCCH wrongly txed as PDTCH

This fixes failure of test TC_rim_ran_info_req_single_rep
It probably broke during some infra refactoring of the PCUIF_Components.

Change-Id: Idf9a38280abd6243cc9ef09fc7d033e515c5be15
---
M pcu/PCUIF_Components.ttcn
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pcu/PCUIF_Components.ttcn b/pcu/PCUIF_Components.ttcn
index 6a24ed6..be7aaeb 100644
--- a/pcu/PCUIF_Components.ttcn
+++ b/pcu/PCUIF_Components.ttcn
@@ -327,7 +327,11 @@
 
 	/* Enqueue DATA.ind and RTS.req messages */
 	[] TC.receive(tr_PCUIF_MSG(PCU_IF_MSG_DATA_IND, bts_nr)) -> value pcu_msg {
-		f_PCUIF_MsgQueue_enqueue(pdtch_data_queue, pcu_msg);
+		if (pcu_msg.u.data_ind.sapi == PCU_IF_SAPI_BCCH) {
+			PCUIF.send(pcu_msg); /* Forward directly ASAP */
+		} else {
+			f_PCUIF_MsgQueue_enqueue(pdtch_data_queue, pcu_msg);
+		}
 		repeat;
 		}
 	[] TC.receive(tr_PCUIF_RTS_REQ(bts_nr, sapi := PCU_IF_SAPI_PDTCH)) -> value pcu_msg {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23801
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idf9a38280abd6243cc9ef09fc7d033e515c5be15
Gerrit-Change-Number: 23801
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/b1b77e66/attachment.htm>


More information about the gerrit-log mailing list