This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23785 ) Change subject: update neighbor ARFCNs on startup and config changes ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_vty.c@2453 PS1, Line 2453: gsm_net_set_system_infos > So if it fails and returns x != 0, we still return CMD_SUCCESS? yes, because the CI got set successfully, doesn't make sense to fail if some neighbor config or system information of some other BTS is incorrect https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/osmo_bsc_main.c@947 PS1, Line 947: gsm_net_set_system_infos > Do we care about the returned value? not really. This is mostly a convenience thing to see the neighbor ARFCNs in the 'show bts' output. System infos will be regenerated after OML and RSL bringup, that code path should care about the return value. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2222e029fc225152e124ed1e8887f1ffd4a107ef Gerrit-Change-Number: 23785 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Apr 2021 00:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210420/9c1c7cab/attachment.htm>