Change in osmo-bsc[master]: SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 19 15:40:01 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23753 )

Change subject: SRVCC: Parse Last Used E-UTRAN PLMN Id in Handover Request
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c 
File src/osmo-bsc/handover_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23753/6/src/osmo-bsc/handover_fsm.c@439 
PS6, Line 439: TLVP_VAL
> What if length of the value part is shorter than 3 bytes? I would use: […]
That's already being checked by tlv_parse with gsm0808_old_bss_to_new_bss_info_att_tlvdef() above.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23753
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia5008f11a4c36ef8085a2037d4abddd131086e6e
Gerrit-Change-Number: 23753
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 19 Apr 2021 15:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210419/8ededc27/attachment.htm>


More information about the gerrit-log mailing list