Change in osmo-msc[master]: Make UTRAN encryption algorithms configurable

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 19 14:24:15 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/22766 )

Change subject: Make UTRAN encryption algorithms configurable
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c 
File src/libmsc/msc_net_init.c:

https://gerrit.osmocom.org/c/osmo-msc/+/22766/1/src/libmsc/msc_net_init.c@71 
PS1, Line 71: 	net->uea_encryption_mask = (1 << 2) | (1 << 1);
> Maybe it is better to add some define constants, also together with the greater-then logic in gsm_04 […]
agree with dexter, having bitmask enums/defines would help. Also some macro for the code checking whether encryption is enabled (!= EA0).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/22766
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I91f9e50f9c1439aa19528f887b83ae9de628fcfd
Gerrit-Change-Number: 22766
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Apr 2021 14:24:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210419/f4bef832/attachment.htm>


More information about the gerrit-log mailing list