Change in osmo-ttcn3-hacks[master]: ns: TC_sns_bss_change_weight_timeout rework TC to use g_handle_rx_alive

laforge gerrit-no-reply at lists.osmocom.org
Mon Apr 19 06:09:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23756 )

Change subject: ns: TC_sns_bss_change_weight_timeout rework TC to use g_handle_rx_alive
......................................................................

ns: TC_sns_bss_change_weight_timeout rework TC to use g_handle_rx_alive

With g_handle_rx_alive the test case doesn't need to use alt{}
as f_ns_exp takes care of the NS_ALIVE.

Related: OS#5036
Change-Id: I45f4392b556912bf60859f354a5687a44e6beeb1
---
M ns/NS_Tests.ttcn
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 29e5669..f69bbe0 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -469,6 +469,7 @@
 }
 
 testcase TC_sns_bss_change_weight() runs on RAW_Test_CT {
+	g_handle_rx_alive := true;
 	f_init_vty();
 	f_init_ns_codec(mp_nsconfig);
 	f_incoming_sns_size();
@@ -487,6 +488,7 @@
 	var template PDU_NS rx;
 	var NSVCConfiguration nsvc_cfg;
 
+	g_handle_rx_alive := true;
 	f_init_vty();
 	f_init_ns_codec(mp_nsconfig);
 	f_incoming_sns_size();
@@ -507,14 +509,8 @@
 		rx := tr_SNS_CHG_WEIGHT(g_nsconfig.nsei, ?, v4 := omit, v6 := v6_elem);
 	}
 
-	alt {
-	[] NSCP[0].receive(rx) {
-		i := i + 1;
-		if (i < 3) {
-			repeat;
-		}
-	}
-	[] as_rx_alive_tx_ack();
+	for (i := 0; i < 3; i := i + 1) {
+		f_ns_exp(rx);
 	}
 
 	if (nsvc_cfg.provider.ip.address_family == AF_INET) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23756
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45f4392b556912bf60859f354a5687a44e6beeb1
Gerrit-Change-Number: 23756
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210419/b9aea948/attachment.htm>


More information about the gerrit-log mailing list