Change in osmo-ttcn3-hacks[master]: ns: TC_sns_bss_change_weight_timeout: fix expected SNS_SIZE PDU

laforge gerrit-no-reply at lists.osmocom.org
Mon Apr 19 06:09:14 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23755 )

Change subject: ns: TC_sns_bss_change_weight_timeout: fix expected SNS_SIZE PDU
......................................................................

ns: TC_sns_bss_change_weight_timeout: fix expected SNS_SIZE PDU

Allow to work with IPv4 and IPv6 endpoints and only expected known required
fields (e.g. NSEI and rst_flag).

Related: OS#5036
Change-Id: I60f669d7c8838d460a14c6604c4375a8d47f5149
---
M ns/NS_Tests.ttcn
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn
index 1715b2e..29e5669 100644
--- a/ns/NS_Tests.ttcn
+++ b/ns/NS_Tests.ttcn
@@ -517,8 +517,16 @@
 	[] as_rx_alive_tx_ack();
 	}
 
-	f_ns_exp(tr_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := 8,
-				   num_v4 := 4, num_v6 := omit), 0);
+	if (nsvc_cfg.provider.ip.address_family == AF_INET) {
+		/* expect one single SNS-SIZE with RESET flag; 4x v4 EP; no v6 EP */
+		rx := f_ns_exp(tr_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := ?,
+					   num_v4 := ?, num_v6 := omit), 0);
+	} else {
+		/* expect one single SNS-SIZE with RESET flag; no v4 EP; 4x v6 EP */
+		rx := f_ns_exp(tr_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := ?,
+					   num_v4 := omit, num_v6 := ?), 0);
+	}
+
 	setverdict(pass);
 	f_clean_ns_codec();
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23755
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I60f669d7c8838d460a14c6604c4375a8d47f5149
Gerrit-Change-Number: 23755
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210419/fe81129d/attachment.htm>


More information about the gerrit-log mailing list