Change in osmo-bsc[master]: update neighbor ARFCNs on startup and config changes

fixeria gerrit-no-reply at lists.osmocom.org
Sun Apr 18 19:43:09 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23785 )

Change subject: update neighbor ARFCNs on startup and config changes
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_init.c 
File src/osmo-bsc/bsc_init.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_init.c@177 
PS1, Line 177: 		int rc = gsm_bts_set_system_infos(bts);
This could be done simpler:

  ret |= gsm_bts_set_system_infos(bts);

but I am also ok with the current approach.


https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/bsc_vty.c@2453 
PS1, Line 2453: gsm_net_set_system_infos
So if it fails and returns x != 0, we still return CMD_SUCCESS?


https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/osmo_bsc_main.c 
File src/osmo-bsc/osmo_bsc_main.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23785/1/src/osmo-bsc/osmo_bsc_main.c@947 
PS1, Line 947: gsm_net_set_system_infos
Do we care about the returned value?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23785
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2222e029fc225152e124ed1e8887f1ffd4a107ef
Gerrit-Change-Number: 23785
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Apr 2021 19:43:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210418/7ae6a8ab/attachment.htm>


More information about the gerrit-log mailing list