Change in libosmocore[master]: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 18 06:45:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23760 )

Change subject: gsm: Support Sending Last EUTRAN PLMN Id in Handover Required
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

I don't think we should invest time in fancy runtime ABI incompatibility detection.  We bump the LIBVERSION when we tag a new release, as always.

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h 
File include/osmocom/gsm/gsm0808.h:

https://gerrit.osmocom.org/c/libosmocore/+/23760/2/include/osmocom/gsm/gsm0808.h@129 
PS2, Line 129: 	/
please move/keep the comment below above the more_items. Otherwise it doesn't really make sense above the last_eutran_plmn_*



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23760
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6280ce1abc283f1491bc6f391b2dd952df33a16b
Gerrit-Change-Number: 23760
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Sun, 18 Apr 2021 06:45:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210418/fffe021e/attachment.htm>


More information about the gerrit-log mailing list