Change in osmo-bsc[master]: Send EUTRAN neighs based on whether Common Id msg contained Last used...

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 16 15:26:11 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23734 )

Change subject: Send EUTRAN neighs based on whether Common Id msg contained Last used E-UTRAN PLMN ID
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/include/osmocom/bsc/bsc_subscriber.h 
File include/osmocom/bsc/bsc_subscriber.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/include/osmocom/bsc/bsc_subscriber.h@48 
PS5, Line 48: struct bsc_subscr *bsub
also const


https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/src/osmo-bsc/bsc_subscr_conn_fsm.c 
File src/osmo-bsc/bsc_subscr_conn_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23734/5/src/osmo-bsc/bsc_subscr_conn_fsm.c@885 
PS5, Line 885: TLVP_VAL
I guess you meant TLVP_PRES or even TLVP_PRES_LEN here?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23734
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5d290ac55eca5adde1c33396422f4c10b83c03d5
Gerrit-Change-Number: 23734
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Apr 2021 15:26:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/5373d476/attachment.htm>


More information about the gerrit-log mailing list