Change in osmo-sgsn[master]: mm_state_{gb, iu}_fsm: Improve naming for detach event

pespin gerrit-no-reply at lists.osmocom.org
Wed Apr 14 15:06:54 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/23750 )

Change subject: mm_state_{gb,iu}_fsm: Improve naming for detach event
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> Not 100% sure about this. (+1, but fine with merging).
> We can rename it. The original idea was to have an IMPLICIT DETACH
> as well a GPRS_DETACH which is the common case, when requested, while implicit detach is used when not explicit requested.

I agree that was the intial idea, but the implemented code always goes through the same code path, so there's no really a distinction, and hence it makes sense to make the naming generic, since anyway they are handled the same way by the FSM.
It would make sense having different events if they were sent from different code paths and/or they were handled differently, which is not the case.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I224ea9db80b4d96696934cea06349dab036f919b
Gerrit-Change-Number: 23750
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 14 Apr 2021 15:06:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210414/50f825ce/attachment.htm>


More information about the gerrit-log mailing list