Change in pysim[master]: init_reader: Print device name/number of chosen reader

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 14 10:45:24 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23720 )

Change subject: init_reader: Print device name/number of chosen reader
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

See comment, unfortunately this interferes with the tests.

https://gerrit.osmocom.org/c/pysim/+/23720/1/pySim/transport/__init__.py 
File pySim/transport/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/23720/1/pySim/transport/__init__.py@185 
PS1, Line 185: 			print("Using PC/SC reader interface (dev_number=%u)" % opts.pcsc_dev)
Since this line also ends up in the results we use to compare when we are running the tests this is is a problem. We had this line before, but we decided to remove it.

(We could also keep it but then we need to regenerate the .ok files and take care that the reader enumeration keeps always the same. Also we must not swap cards then.)



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23720
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I87fd934243bc3556fd6db0ce6d219c22a60c2db4
Gerrit-Change-Number: 23720
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Apr 2021 10:45:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210414/25eff64c/attachment.htm>


More information about the gerrit-log mailing list