Change in osmo-sgsn[master]: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 13 18:36:16 UTC 2021


Hello Jenkins Builder, laforge, daniel, lynxis lazus, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-sgsn/+/23743

to look at the new patch set (#3).

Change subject: mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED
......................................................................

mm_state_iu_fsm: T3314 expiry must lead to PMM IDLE, not PMM DETACHED

This Iu timer is Osmocom specific, but is made to resemble T3314 timer
from GERAN (also named READY timer). The READY timer mission is to make
the MM state transition from READY to STANDBY, which in PMM (UTRAN)
matches the transition from CONNECTED to IDLE.
Instead, the patch introducing the timer was making it transition to
DETACHED directly, but this was clearly not the intention:
* Detaching a UE after 44 seconds (default value for T3314) is overkill.
* The comment describing it says: "Iu User inactivity timer. On expiry
  release Iu connection". The release of Iu connection happens during
  the CONNECTED->IDLE transition (that's basically the difference between
  both states).

The transition CONNECTED->IDLE is done by means of calling
sgsn_ranap_iu_release_free(), which will eventually answer with a event
RANAP_IU_EVENT_IU_RELEASE from lower layers when the Release Complete is
received. At that point, osmo-sgsn code frees the connection and
transitions to IDLE state. This way we maintain the state according to
the connection existance.

Related: SYS#5389
Related: osmo-iuh.git Change-Id Iac822c74e56750dc40e94573eae0e20853ff68c0
Fixes: 3bad31bcb42c3449e6847ea7495578817029a2e1
Change-Id: I7279102ad51b0c39eb6d04c129986984112d15cc
---
M src/sgsn/gprs_mm_state_iu_fsm.c
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/43/23743/3
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/23743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I7279102ad51b0c39eb6d04c129986984112d15cc
Gerrit-Change-Number: 23743
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210413/1078ca80/attachment.htm>


More information about the gerrit-log mailing list