Change in pysim[master]: Use construct for EF_AD in pySim-{shell, prog, read}.py, cards.py

Falkenber9 gerrit-no-reply at lists.osmocom.org
Tue Apr 13 09:02:37 UTC 2021


Falkenber9 has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23723 )

Change subject: Use construct for EF_AD in pySim-{shell, prog, read}.py, cards.py
......................................................................


Patch Set 3:

(3 comments)

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > It seems that ``EF_AD`` has only 3 Bytes in ``sysmosim-gr1`` and ``fakemagicsim`` although it should be 4 Bytes?
> 
> I see, only first three bytes are mandatory (M). Further bytes are optional (O)

Updated the structure definition

https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim-read.py@233 
PS2, Line 233: 		ad = EF_AD()
> You can optionally simplify this to: […]
thanks


https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py 
File pySim/construct.py:

https://gerrit.osmocom.org/c/pysim/+/23723/2/pySim/construct.py@56 
PS2, Line 56: FlagRFU=Default(Flag,__RFU_VALUE)
> cosmetic: inconsistent formatting
Thanks


https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok 
File pysim-testdata/Fairwaves-SIM.ok:

https://gerrit.osmocom.org/c/pysim/+/23723/2/pysim-testdata/Fairwaves-SIM.ok@a46 
PS2, Line 46: operation
> Unrelated change?
This comes from removing redundant dictionary "EF_AD_mode_map" in pySim/ts_51_011.py by switching to enum "OP_MODE" with more compact naming of the members (without "operation")



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23723
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I65e0a426f80a619fec38856a30e590f0e726b554
Gerrit-Change-Number: 23723
Gerrit-PatchSet: 3
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Apr 2021 09:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210413/1e760b6f/attachment.htm>


More information about the gerrit-log mailing list