This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23730 ) Change subject: abis_nm_ipaccess_rsl_connect(): use msgb to compose attr ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/23730/2/src/osmo-bsc/abis_nm.c File src/osmo-bsc/abis_nm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23730/2/src/osmo-bsc/abis_nm.c@3025 PS2, Line 3025: msgb_tv16_put(attr, NM_ATT_IPACC_DST_IP_PORT, port); > make sure the endianess is put correctly here. Everything is correct here, tv16_put() does the same: *buf++ = val >> 8; *buf++ = val & 0xff; https://gerrit.osmocom.org/c/osmo-bsc/+/23730/2/src/osmo-bsc/abis_nm.c@3030 PS2, Line 3030: msgb_tv_fixed_put Can we use msgb_tv32_put() here instead? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iba005635cf86aee1fde77d58ef203e28eed92281 Gerrit-Change-Number: 23730 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 12 Apr 2021 17:54:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210412/0076f860/attachment.htm>