Change in osmo-bts[master]: omldummy: introduce using getopt_long

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 12 08:55:09 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23588 )

Change subject: omldummy: introduce using getopt_long
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/23588/3/src/osmo-bts-omldummy/main.c 
File src/osmo-bts-omldummy/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/23588/3/src/osmo-bts-omldummy/main.c@38 
PS3, Line 38: 		static struct option long_options[] = {
having the static var declared inside the while loop is a bit weird imho.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23588
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I72ccf65ba894e87ee7b0f6bed879f94728f34ccc
Gerrit-Change-Number: 23588
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Apr 2021 08:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210412/32a8627a/attachment.htm>


More information about the gerrit-log mailing list