Change in pysim[master]: init_reader: Print device name/number of chosen reader

fixeria gerrit-no-reply at lists.osmocom.org
Sun Apr 11 15:15:59 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23720 )

Change subject: init_reader: Print device name/number of chosen reader
......................................................................


Patch Set 1: Code-Review+1

I vote for this change. We should not make logging messages less informative just because of the design flaws in the build setup (lazy stdout vs file matching). Also, using Python's logging framework instead of print() statements may be the key to improve the situation.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23720
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I87fd934243bc3556fd6db0ce6d219c22a60c2db4
Gerrit-Change-Number: 23720
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Sun, 11 Apr 2021 15:15:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210411/954a0f5a/attachment.htm>


More information about the gerrit-log mailing list