Change in pysim[master]: Add option to set UE operation mode in EF_AD (Administrative Data)

Falkenber9 gerrit-no-reply at lists.osmocom.org
Sat Apr 10 07:35:05 UTC 2021


Falkenber9 has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Add option to set UE operation mode in EF_AD (Administrative Data)
......................................................................


Patch Set 9:

> Patch Set 8: Code-Review+1
> 
> > I fully agree going the more generic way.
> > Nevertheless, I think it is useful to have that option in pySim-prog.
> > We use pySim-prog to conveniently batch-(re)program the Sysmocom uSIMs (the green and black ones) according to configuration in CSV files. Thereby we add "NAME" for SPN and "OPMODE" in additional columns.
> 
> It would be great to work out some strategy for such batch-reprogramming uses cases basd on the new pySim-shell / filesystem.py infrastructure.  pySim-shell is of course highly scriptable.
> 
> Particularly with https://gerrit.osmocom.org/c/pysim/+/23661 and its jsonpath support we can now have a very elegant way to modify only certain logical bits/fields in larger binary files.
> 
> scripting pySim-shell from external scripts however doesn't currently have any kind of CSV import
> or the capability to wait for another card, etc.
> 
> If you have any ideas on how this could/should happen, you now have the chance ot shape the implementation.  I haven't really done much planning that way  yet.

Unfortunately, currently I do not have time to contribute much on that topic. So I have to leave that open (for now).
> 
> > I will rebase the current code for now. Shall we update to use your new code as well?
> 
> I don't currently see how you would use the filesystem/pySim-shell code from pySim-prog. not sure what you meant?

Just updated the patch to use the EF_AD class as used for pySim-shell. Packing, unpacking and updating is way more convenient with the provided methods - thanks for that!


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 9
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 10 Apr 2021 07:35:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210410/85408239/attachment.htm>


More information about the gerrit-log mailing list