Change in pysim[master]: shell: add edit_{record, binary}_decoded shell commands

fixeria gerrit-no-reply at lists.osmocom.org
Thu Apr 8 21:37:24 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23681 )

Change subject: shell: add edit_{record,binary}_decoded shell commands
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks good in general.

https://gerrit.osmocom.org/c/pysim/+/23681/1/pySim/filesystem.py 
File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/23681/1/pySim/filesystem.py@441 
PS1, Line 441:             dirname = tempfile.mkdtemp(prefix='pysim_')
> with tempfile.TemporaryDirectory() as dirname: […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23681
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icf6a6e8529e7664c5645519fb4bdd55b35f34664
Gerrit-Change-Number: 23681
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: tnt <tnt at 246tNt.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/10d62054/attachment.htm>


More information about the gerrit-log mailing list