Change in libosmocore[master]: add osmo_bts_features_names: short BTS feature strings

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 8 21:17:11 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23587 )

Change subject: add osmo_bts_features_names: short BTS feature strings
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/23587/5/src/gsm/bts_features.c 
File src/gsm/bts_features.c:

https://gerrit.osmocom.org/c/libosmocore/+/23587/5/src/gsm/bts_features.c@57 
PS5, Line 57: const struct value_string osmo_bts_features_names[] = {
> I would love to see this block consistent with 'osmo_bts_features_descs', i.e. […]
yes, please let's not take everyone's aesthetics too far.  There's nothing in our coding style requirements about the use of tab-aligend value_string memmbers.


https://gerrit.osmocom.org/c/libosmocore/+/23587/5/src/gsm/libosmogsm.map 
File src/gsm/libosmogsm.map:

https://gerrit.osmocom.org/c/libosmocore/+/23587/5/src/gsm/libosmogsm.map@400 
PS5, Line 400: osmo_bts_features_name
> Do we really need to expose a 'static inline' symbol that is in the header file?
no, because it actually is not a symbol at all.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I699cd27512887d64d824be680303e70fff3677c1
Gerrit-Change-Number: 23587
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:17:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/c758cdd2/attachment.htm>


More information about the gerrit-log mailing list