Change in pysim[master]: pySim-shell: be sure that startup script file exists

laforge gerrit-no-reply at lists.osmocom.org
Thu Apr 8 21:13:47 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23680 )

Change subject: pySim-shell: be sure that startup script file exists
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23680/1/pySim-shell.py 
File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/23680/1/pySim-shell.py@455 
PS1, Line 455: 		if not o
I guess you actually want to try to open and read it.  AFter all, the file could exist and be a file but not be readable by the current user.  And then again you run into the behavior you're trying to avoid (no error message but not terminating due to hidden error)



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23680
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4ff2226c8852727aa23357aa54d1e2d480bfaf2d
Gerrit-Change-Number: 23680
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 08 Apr 2021 21:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/c1bc2294/attachment.htm>


More information about the gerrit-log mailing list