Change in libosmocore[master]: add osmo_bts_features_names: short BTS feature strings

neels gerrit-no-reply at lists.osmocom.org
Thu Apr 8 18:44:55 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23587 )

Change subject: add osmo_bts_features_names: short BTS feature strings
......................................................................


Patch Set 3:

the usual pattern we have is

  enum foobar { ... };
  const char *foobar_name();

It's not really my fault that there was a mess previously,
I think it sucks to deviate from the usual pattern just because some other name failed to be chosen right in the past. No other enum has "_short_" in its name function. I would really hate to have to do that.

I put an API doc to the mis-named function. isn't that sufficient?


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23587
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I699cd27512887d64d824be680303e70fff3677c1
Gerrit-Change-Number: 23587
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 08 Apr 2021 18:44:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210408/d1181d61/attachment.htm>


More information about the gerrit-log mailing list