Change in osmo-msc[master]: SMS-over-GSUP: notify sender if no transaction found

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 7 16:43:22 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17876 )

Change subject: SMS-over-GSUP: notify sender if no transaction found
......................................................................

SMS-over-GSUP: notify sender if no transaction found

Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
---
M src/libmsc/gsm_04_11_gsup.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c
index 1f500d0..7a47e93 100644
--- a/src/libmsc/gsm_04_11_gsup.c
+++ b/src/libmsc/gsm_04_11_gsup.c
@@ -161,7 +161,8 @@
 		LOGP(DLSMS, LOGL_NOTICE, "No transaction found for %s, "
 			"ignoring %s-%s message...\n", vlr_subscr_name(vsub),
 			msg_name, msg_is_err ? "Err" : "Res");
-		return -EIO; /* TODO: notify sender about that? */
+		gsup_client_mux_tx_error_reply(net->gcm, gsup_msg, GMM_CAUSE_NO_PDP_ACTIVATED);
+		return -EIO;
 	}
 
 	LOG_TRANS(trans, LOGL_DEBUG, "RX %s-%s\n", msg_name, msg_is_err ? "Err" : "Res");

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17876
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
Gerrit-Change-Number: 17876
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/5349c82d/attachment.htm>


More information about the gerrit-log mailing list