Change in pysim[master]: ts_102_221.py: fix fixup_fcp_proprietary_tlv_map()

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 7 16:21:52 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23665 )

Change subject: ts_102_221.py: fix fixup_fcp_proprietary_tlv_map()
......................................................................

ts_102_221.py: fix fixup_fcp_proprietary_tlv_map()

The function fixup_fcp_proprietary_tlv_map() addes propritary TLV
tags in the range of d0 to ff to the TLV map. However, the spec defines
this range as b7 and b8 of the first tag byte set to 1. This results
in a range from c0 to ff. See also ETSI TS 102 221, section 11.1.1.4.6.0

Change-Id: I8359527c9ff303b257b181b87dc440f27735ece9
Related: OS#4963
---
M pySim/ts_102_221.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/pySim/ts_102_221.py b/pySim/ts_102_221.py
index b8fce1b..88a36a1 100644
--- a/pySim/ts_102_221.py
+++ b/pySim/ts_102_221.py
@@ -129,7 +129,7 @@
 def fixup_fcp_proprietary_tlv_map(tlv_map):
     if 'D0' in tlv_map:
         return
-    for i in range(0xd0, 0xff):
+    for i in range(0xc0, 0xff):
         i_hex = i2h([i]).upper()
         tlv_map[i_hex] = 'proprietary_' + i_hex
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23665
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8359527c9ff303b257b181b87dc440f27735ece9
Gerrit-Change-Number: 23665
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/3868bb0f/attachment.htm>


More information about the gerrit-log mailing list