Change in pysim[master]: SysmoISIM-SJA2: Add option to set Service Provider Name (SPN)

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 7 16:21:15 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/23652 )

Change subject: SysmoISIM-SJA2: Add option to set Service Provider Name (SPN)
......................................................................

SysmoISIM-SJA2: Add option to set Service Provider Name (SPN)

Same implementation as for sysmoUSIM-SJS1

Change-Id: I3a9dd2fe85126584758ea4cfa127f9cd14ab0c7d
---
M pySim/cards.py
M pysim-testdata/sysmoISIM-SJA2.ok
2 files changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  dexter: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/pySim/cards.py b/pySim/cards.py
index 5eb2884..ad6ddbc 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -1266,6 +1266,11 @@
 		# select DF_GSM
 		self._scc.select_path(['7f20'])
 
+		# set Service Provider Name
+		if p.get('name') is not None:
+			content = enc_spn(p['name'], True, True)
+			data, sw = self._scc.update_binary('6F46', rpad(content, 32))
+
 		# write EF.IMSI
 		if p.get('imsi'):
 			self._scc.update_binary('6f07', enc_imsi(p['imsi']))
diff --git a/pysim-testdata/sysmoISIM-SJA2.ok b/pysim-testdata/sysmoISIM-SJA2.ok
index b2de818..ae332a8 100644
--- a/pysim-testdata/sysmoISIM-SJA2.ok
+++ b/pysim-testdata/sysmoISIM-SJA2.ok
@@ -6,9 +6,9 @@
 GID1: ffffffffffffffffffff
 GID2: ffffffffffffffffffff
 SMSP: ffffffffffffffffffffffffffffffffffffffffffffffffe1ffffffffffffffffffffffff0581005155f5ffffffffffff000000
-SPN: Not available
-Display HPLMN: False
-Display OPLMN: False
+SPN: Magic
+Display HPLMN: True
+Display OPLMN: True
 PLMNsel: 00f110ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
 PLMNwAcT:
 	00f110ffff # MCC: 001 MNC: 001 AcT: UTRAN, E-UTRAN, GSM, GSM COMPACT, cdma2000 HRPD, cdma2000 1xRTT

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3a9dd2fe85126584758ea4cfa127f9cd14ab0c7d
Gerrit-Change-Number: 23652
Gerrit-PatchSet: 3
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/7b86fdc3/attachment.htm>


More information about the gerrit-log mailing list