Change in simtrace2[master]: firmware: qmod-dfu: disable stack protector

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 7 14:54:22 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23674 )

Change subject: firmware: qmod-dfu: disable stack protector
......................................................................

firmware: qmod-dfu: disable stack protector

Prevent build failure on debian 9, ubuntu 20.04, 20.10, where
bin/qmod-dfu-flash.elf does not fit the ROM.

Fixes: OS#5081
Change-Id: I9fffe4c323094679062428f41a4246b1c1b30ca2
---
M firmware/Makefile
1 file changed, 6 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Hoernchen: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/firmware/Makefile b/firmware/Makefile
index 2d0f62c..b147b0d 100644
--- a/firmware/Makefile
+++ b/firmware/Makefile
@@ -59,6 +59,11 @@
 BIN = bin
 OBJ = obj/$(BOARD)
 
+# Disable stack protector for code in small ROM regions (OS#5081)
+ifeq ($(BOARD)-$(APP), qmod-dfu)
+CFLAGS_EXTRA ?= -fno-stack-protector
+endif
+
 #-------------------------------------------------------------------------------
 #		Tools
 #-------------------------------------------------------------------------------
@@ -178,6 +183,7 @@
 CFLAGS += -DGIT_VERSION=\"$(GIT_VERSION)\"
 CFLAGS += -DBOARD=\"$(BOARD)\" -DBOARD_$(BOARD)
 CFLAGS += -DAPPLICATION=\"$(APP)\" -DAPPLICATION_$(APP)
+CFLAGS += $(CFLAGS_EXTRA)
 ASFLAGS = -mcpu=cortex-m3 -mthumb -Wall -g $(OPTIMIZATION) $(INCLUDES) -D$(CHIP) -D__ASSEMBLY__
 LDFLAGS = -mcpu=cortex-m3 -mthumb -Wl,--cref -Wl,--check-sections -Wl,--gc-sections -Wl,--entry=ResetException -Wl,--unresolved-symbols=report-all -Wl,--warn-common -Wl,--warn-section-align -Wl,--print-memory-usage -Wl,--no-undefined $(LIB)
 #LD_OPTIONAL=-Wl,--print-gc-sections -Wl,--stats

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23674
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9fffe4c323094679062428f41a4246b1c1b30ca2
Gerrit-Change-Number: 23674
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/ad7861d9/attachment.htm>


More information about the gerrit-log mailing list