Change in pysim[master]: SysmoISIM-SJA2: Add option to set Service Provider Name (SPN)

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 7 13:21:39 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23652 )

Change subject: SysmoISIM-SJA2: Add option to set Service Provider Name (SPN)
......................................................................


Patch Set 3: Code-Review+1

> Patch Set 3:
> 
> I suspect this patch recurrently breaks all (subsequent) tests that run on a codebase that does not include this patch (due to its persistent change of the SPN in the unit under test).
> 
> Related Fun-Fact: It seems that currently sold black sysmocom USIMs are shipped without the SPN set to "Magic".

Hello.

Yes, there is indeed a problem. This patch indeed breaks the build process. Unfortunately we currently have no way to isolate the test from each other since they are executed on physical cards. We are working on a way to reset all cards to a defined state after each build. For now the problem should go away once this patch is merged. I will keep an eye on this.

Best regards.
Philipp


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23652
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3a9dd2fe85126584758ea4cfa127f9cd14ab0c7d
Gerrit-Change-Number: 23652
Gerrit-PatchSet: 3
Gerrit-Owner: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Wed, 07 Apr 2021 13:21:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/19b1e97c/attachment.htm>


More information about the gerrit-log mailing list