Change in pysim[master]: pySim-shell: JSONpath support for updating files/records

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 7 13:12:01 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23661 )

Change subject: pySim-shell: JSONpath support for updating files/records
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.osmocom.org/c/pysim/+/23661/3/pySim/jsonpath.py 
File pySim/jsonpath.py:

https://gerrit.osmocom.org/c/pysim/+/23661/3/pySim/jsonpath.py@1 
PS3, Line 1: import json
> The copyright header is missing.
Done


https://gerrit.osmocom.org/c/pysim/+/23661/3/pySim/jsonpath.py@4 
PS3, Line 4: jsonpath
> Looks like it's imported, but not used?
Done


https://gerrit.osmocom.org/c/pysim/+/23661/3/pySim/jsonpath.py@6 
PS3, Line 6: utliity
> typo
Done


https://gerrit.osmocom.org/c/pysim/+/23661/3/pySim/jsonpath.py@15 
PS3, Line 15: givne
even more typos you didn't spot :P



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iad09b3d878b8b58ad34cb549c80f8a6eb3149faa
Gerrit-Change-Number: 23661
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Falkenber9 <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Comment-Date: Wed, 07 Apr 2021 13:12:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/a0bedd47/attachment.htm>


More information about the gerrit-log mailing list