Change in pysim[master]: commands, ts_102_221: replace pytlv with uttlv

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 7 09:04:40 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23483 )

Change subject: commands, ts_102_221: replace pytlv with uttlv
......................................................................


Patch Set 6: Code-Review-1

I originally thought that migrating from pytlv to uttlv might solve problems, but apparently it tends to create even more problems.

One problem we stumble upon repeatedly is that that when the parser hits undefined TLV elements it throws an exception. This behavior is wrong since TLV was designed explicitly with the idea in mind that one could add IEs afterwards and still be compatible with older parsers. Uttlv does not have this issue, but it seems to have other problems. It is probably not helpful to migrate to uttlv now. However it is also not pressing at the moment.

I think we should abandon this and look for something else in the long run.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23483
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I971b818836aff2fbeb6769f819d496cee4bfa7cf
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: merlinchlosta <merlin.chlosta at rub.de>
Gerrit-Comment-Date: Wed, 07 Apr 2021 09:04:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210407/b33415ce/attachment.htm>


More information about the gerrit-log mailing list