Change in pysim[master]: Add option to set UE operation mode in EF_AD (Administrative Data)

Robert Falkenberg gerrit-no-reply at lists.osmocom.org
Tue Apr 6 19:35:48 UTC 2021


Robert Falkenberg has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23632 )

Change subject: Add option to set UE operation mode in EF_AD (Administrative Data)
......................................................................


Patch Set 6:

> Patch Set 6:
> 
> I've now added the missing support to pySim-shell in https://gerrit.osmocom.org/c/pysim/+/23658
> 
> If you still think it is important to add this also to pySim-prog, we can go ahead with it.  I personally think all new features must be supported in pySim-shell, which is much more general and flexible in terms of supportin the quadrillion of parameters in all the sim/usim/isim files...

Great, thanks for the quick support!

I fully agree going the more generic way.
Nevertheless, I think it is useful to have that option in pySim-prog.
We use pySim-prog to conveniently batch-(re)program the Sysmocom uSIMs (the green and black ones) according to configuration in CSV files. Thereby we add "NAME" for SPN and "OPMODE" in additional columns.
The cmdline param --OPMODE is only added for completeness.

I will rebase the current code for now. Shall we update to use your new code as well?


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23632
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9040c6b127c268878a0845ed73d0918ec6bbb08
Gerrit-Change-Number: 23632
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Falkenberg <robert.falkenberg at tu-dortmund.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 06 Apr 2021 19:35:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/065b8ffb/attachment.htm>


More information about the gerrit-log mailing list