Change in libosmocore[master]: stat_item: make value ids item specific

daniel gerrit-no-reply at lists.osmocom.org
Tue Apr 6 16:31:43 UTC 2021


daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/23508 )

Change subject: stat_item: make value ids item specific
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c 
File src/stat_item.c:

https://gerrit.osmocom.org/c/libosmocore/+/23508/1/src/stat_item.c@280 
PS1, Line 280: 	return 0;
> It doesn't call osmo_stats_discard_all() here, because osmo_stats_discard_all() uses item->stats_nex […]
In that case I would bump the log level above up to error (or at least notice) and maybe also log that this function is a nop.

There is no reason to use this function and using it will do nothing.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/23508
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie65dcdf52c8fc3d916e20d7f0455f6223be6b64f
Gerrit-Change-Number: 23508
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Apr 2021 16:31:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/51e0b7f8/attachment.htm>


More information about the gerrit-log mailing list