Change in osmo-ttcn3-hacks[master]: pcu: SNS: add TC_sns_1c1u_unconfigured_nsvc

laforge gerrit-no-reply at lists.osmocom.org
Tue Apr 6 15:47:26 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23655 )

Change subject: pcu: SNS: add TC_sns_1c1u_unconfigured_nsvc
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23655/1/pcu/PCU_Tests_SNS.ttcn 
File pcu/PCU_Tests_SNS.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23655/1/pcu/PCU_Tests_SNS.ttcn@228 
PS1, Line 228: 	f
you could do this probably more elegant (and less dependent on VTY format changes) by using the CTRL interface to perform FSM state introspection? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23554 and https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23555 as an usage example.

Not saying one must do that, just pointing it out as an option to verify the state of specific FSMs.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23655
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iac6c8966aafd1cb2fab515de091e94607eb7c040
Gerrit-Change-Number: 23655
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 06 Apr 2021 15:47:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210406/85998e06/attachment.htm>


More information about the gerrit-log mailing list